AbstractSniffTestCase: flag missing .fixed files
#999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per issue 300, the PHPCS native `AbstractSniffUnitTest` test case should flag sniff test case files which would lead to fixes, but for which no `.fixed` file is available to verify the fixes against. It should also fail a test run when this occurs. This commit makes it so. Fixes 300
rodrigoprimo
approved these changes
Apr 15, 2025
jrfnl
deleted the
phpcs-4.0/feature/300-abstractsniffunittest-flag-missing-fixes-files
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per issue #300, the PHPCS native
AbstractSniffUnitTesttest case should flag sniff test case files which would lead to fixes, but for which no.fixedfile is available to verify the fixes against.It should also fail a test run when this occurs.
This commit makes it so.
Suggested changelog entry
Changed:
All test case files (
inc) which would be changed by the sniff under test if running the fixer, are now required to be accompanied by a*.fixedfile.Related issues/external references
Fixes #300